Skip to content

branch-3.0: [Fix](full compaction) Fix problems for full compaction #49825 - #49917

Merged
dataroaring merged 1 commit into
branch-3.0from
auto-pick-49825-branch-3.0
Apr 10, 2025
Merged

branch-3.0: [Fix](full compaction) Fix problems for full compaction #49825#49917
dataroaring merged 1 commit into
branch-3.0from
auto-pick-49825-branch-3.0

Conversation

@github-actions

@github-actions github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

Cherry-picked from #49825

### What problem does this PR solve?

1. in local mode, full compaction should update tablet's rowsets meta
and delete bitmaps for incremental rowsets under same lock.
2. in local mode, full compaction should not preserve delete bitmap
sentinel marks.
3. in cloud mode, full compaction should update correct delete bitmaps'
version for incremental rowsets.
@github-actions
github-actions Bot requested a review from dataroaring as a code owner April 9, 2025 11:33
@Thearas

Thearas commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Apr 9, 2025
@dataroaring dataroaring reopened this Apr 9, 2025
@Thearas

Thearas commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/60) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.04% (10488/26195)
Line Coverage 30.72% (88151/286961)
Region Coverage 29.83% (45431/152310)
Branch Coverage 26.20% (23037/87914)

@dataroaring dataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 3de3682 into branch-3.0 Apr 10, 2025
@github-actions
github-actions Bot deleted the auto-pick-49825-branch-3.0 branch April 10, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants